-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary features automatically enabled by default. #13602
Comments
This is tested on |
@hydra: someone spent considerable effort to enable these features (config and feature handling is total mess). Maybe we can use different values of USE_ define?
with some improvement/rewording |
It seems there's some work going on in #13494 butwith reference to https://github.com/betaflight/betaflight/pull/13494/files#r1605977635 we must not forget the commit or additional PR that fixes the bug described in the OP #13602 (comment). |
Describe the bug
After issuing 'defaults' in the cli, and then 'diff' I get this:
The target has various, 'USE_...' defined, e.g. 'USE_SERVOS', but that shouldn't mean that features using the code enabled by the define should be used.
To Reproduce
Expected behavior
Only the features actually wanted are enabled. i.e. none of the above should be enabled by default.
Support ID
Flight controller
Any H7
Other components
No response
How are the different components wired up (including port information)
No response
Add any other context about the problem that you think might be relevant here
See
validateAndFixConfig
.e.g.
The text was updated successfully, but these errors were encountered: