Do not enable features by default

[haslinghuis]

• Fixes Dashboard build option impedes Betaflight initialization and creates I2C errors. #13590
• Fixes Unnecessary features automatically enabled by default. #13602
• See also Improve features (+ cli) #13494 which should be merged first
• Remember Fix arming when GPS included in build but no active GNSS device attached + revert msp request for SatInfo #13244

[github-actions]

Do you want to test this code? You can flash it directly from Betaflight Configurator:

• Simply put #13608 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

[ledvinap]

This should be accompanied with documentation change.

Also, some features should be enabled - for example with OSD integrated FC, you want FEATURE_OSD almost universally.

[ledvinap]

For consideration:

#if defined(USE_OSD) && USE_OSD >= 2

It will allow config.h to #define USE_OSD 2 and make <target> OPTIONS='USE_OSD=2

[haslinghuis]

Was thinking about missing default features from unified_targets and adding in config.h something like:

#define DEFAULT_FEATURES     (FEATURES_OSD)

[ledvinap]

@haslinghuis : https://github.com/betaflight/betaflight/pull/13494/files#diff-384c3b23c60da197eb7ecccd9bbfd19d68d96245f45181ec4db541e9c1014b92R418-R432

All that is necessary is to define autoFeatures by target

[haslinghuis]

Updated and tested.

[ledvinap]

@haslinghuis problem is that you want osd only on targets with integrated osd. the same with other features...

[haslinghuis]

@ledvinap OSD feature is also used when using MSP instead of MAX7456

[hydra]

@haslinghuis problem is that you want osd only on targets with integrated osd. the same with other features...

I think the situations where you want it enabled by default are as follows:

1. FC has OSD on-board. (MAX7456/AT7456, FrSkyOSD, SPRacingPixelOSD, etc)
2. FC has HD/DJI OSD connector or is always paired with an MSP DisplayPort device (daughter board, stack, etc) and one serial port is configured by default to use MSP DisplayPort.

[haslinghuis]

Currently

• OSD_SD and OSD_HD is a default build option. User should choose which one or neither to use.
• Including OSD_HD defaults to MSP displayport as switching between analog or hd video system does not work in respect to positioning the elements.

[haslinghuis]

This should be depend on USE_OSD included.

[haslinghuis]

Fixed + rebased on master

[haslinghuis]

Closing in favor of #13494

[hydra]

Closing in favor of #13494

#13494 still enables some features by default, this issue isn't resolved and won't be until another PR to change the features is created, see https://github.com/betaflight/betaflight/pull/13494/files#r1605977635

[haslinghuis]

Okay, will wait for #13494 to be merged and work from there.

EDIT: rebased on master, removed some features which perhaps should be enabled manually.