Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TightVNC 2.8.81 #6

Open
HeliusHao opened this issue May 16, 2023 · 7 comments
Open

TightVNC 2.8.81 #6

HeliusHao opened this issue May 16, 2023 · 7 comments

Comments

@HeliusHao
Copy link

HeliusHao commented May 16, 2023

No description provided.

@chenall
Copy link
Owner

chenall commented May 18, 2023

已经更新上传

@chenall chenall closed this as completed May 18, 2023
@QQ2017
Copy link

QQ2017 commented Jun 2, 2023

已经更新上传

发现有些修改会覆盖官方的BUG修复,我认为版主应该重新检查修改的代码,基于官方代码重新修改

比如下面的代码右侧是官方相同版本的代码(tightvnc-2.8.81-gpl),很明显此处是做了更多判断,ini版本把这块去掉了:
image

后面发现版主的代码版本似乎是 tightvnc-2.8.79
image

@HeliusHao
Copy link
Author

HeliusHao commented Jun 2, 2023 via email

@QQ2017
Copy link

QQ2017 commented Jun 2, 2023

他应该是更新的二进制文件,对比了下修改处,似乎修改的也不多,有空可以自己改下。。

@HeliusHao
Copy link
Author

他应该是更新的二进制文件,对比了下修改处,似乎修改的也不多,有空可以自己改下。。

说实话,不会改。^_^

@chenall
Copy link
Owner

chenall commented Jun 17, 2023

已经更新上传

发现有些修改会覆盖官方的BUG修复,我认为版主应该重新检查修改的代码,基于官方代码重新修改

比如下面的代码右侧是官方相同版本的代码(tightvnc-2.8.81-gpl),很明显此处是做了更多判断,ini版本把这块去掉了: image

后面发现版主的代码版本似乎是 tightvnc-2.8.79 image

你对比的是哪个版本? upstream 是这官方的版本
main 是修改的(不经常更新)

编译时要把 upstream 的版本合并到 main 下再编译.

正常情况下我只更新 upstream 的版本.

有需要的可以自己合并一下就是最新的修改版本代码.

@chenall chenall reopened this Jun 17, 2023
@chenall
Copy link
Owner

chenall commented Jun 17, 2023

#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants