HandleMultipleEntryRar memory leak fix with auto-destructor (#2698)

clsid2 · Apr 1, 2024 · 1972f8d · 1972f8d
1 parent 2aca354
commit 1972f8d
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/mpc-hc/MainFrm.cpp b/src/mpc-hc/MainFrm.cpp
@@ -12850,7 +12850,7 @@ HRESULT CMainFrame::PreviewWindowShow(REFERENCE_TIME rtCur2) {
 }
 
 HRESULT CMainFrame::HandleMultipleEntryRar(CStringW fn) {
-    CRFSList <CRFSFile> file_list;
+    CRFSList <CRFSFile> file_list(true); //true = clears itself on destruction
     int num_files, num_ok_files;
 
     CRARFileSource::ScanArchive(fn.GetBuffer(), &file_list, &num_files, &num_ok_files);
@@ -12859,12 +12859,10 @@ HRESULT CMainFrame::HandleMultipleEntryRar(CStringW fn) {
         if (IDOK == entrySelector.DoModal()) {
             CStringW entryName = entrySelector.GetCurrentEntry();
             if (entryName.GetLength() > 0) {
-                file_list.Clear();
                 CComPtr<CFGManager> fgm = static_cast<CFGManager*>(m_pGB.p);
                 return fgm->RenderRFSFileEntry(fn, nullptr, entryName);
             }
         }
-        file_list.Clear();
         return RFS_E_ABORT; //we found multiple entries but no entry selected.
     }
     return E_NOTIMPL; //not a multi-entry rar