Only gather statistics data when statistics panel is visible.

clsid2 · Mar 6, 2024 · d19bb0d · d19bb0d
1 parent 872a55d
commit d19bb0d
Showing 1 changed file with 63 additions and 62 deletions.
diff --git a/src/mpc-hc/MainFrm.cpp b/src/mpc-hc/MainFrm.cpp
@@ -2129,88 +2129,89 @@ void CMainFrame::OnTimer(UINT_PTR nIDEvent)
             }
             break;
         case TIMER_STATS: {
-            CString rate;
-            rate.Format(_T("%.3fx"), m_dSpeedRate);
-            if (m_pQP) {
-                CString info;
-                int tmp, tmp1;
-
-                if (SUCCEEDED(m_pQP->get_AvgFrameRate(&tmp))) { // We hang here due to a lock that never gets released.
-                    info.Format(_T("%d.%02d (%s)"), tmp / 100, tmp % 100, rate.GetString());
-                } else {
-                    info = _T("-");
-                }
-                m_wndStatsBar.SetLine(StrRes(IDS_AG_FRAMERATE), info);
+            const CAppSettings& s = AfxGetAppSettings();
+            if (m_wndStatsBar.IsVisible()) {
+                CString rate;
+                rate.Format(_T("%.3fx"), m_dSpeedRate);
+                if (m_pQP) {
+                    CString info;
+                    int tmp, tmp1;
+
+                    if (SUCCEEDED(m_pQP->get_AvgFrameRate(&tmp))) { // We hang here due to a lock that never gets released.
+                        info.Format(_T("%d.%02d (%s)"), tmp / 100, tmp % 100, rate.GetString());
+                    } else {
+                        info = _T("-");
+                    }
+                    m_wndStatsBar.SetLine(StrRes(IDS_AG_FRAMERATE), info);
 
-                if (SUCCEEDED(m_pQP->get_AvgSyncOffset(&tmp))
+                    if (SUCCEEDED(m_pQP->get_AvgSyncOffset(&tmp))
                         && SUCCEEDED(m_pQP->get_DevSyncOffset(&tmp1))) {
-                    info.Format(IDS_STATSBAR_SYNC_OFFSET_FORMAT, tmp, tmp1);
-                } else {
-                    info = _T("-");
-                }
-                m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_SYNC_OFFSET), info);
+                        info.Format(IDS_STATSBAR_SYNC_OFFSET_FORMAT, tmp, tmp1);
+                    } else {
+                        info = _T("-");
+                    }
+                    m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_SYNC_OFFSET), info);
 
-                if (SUCCEEDED(m_pQP->get_FramesDrawn(&tmp))
+                    if (SUCCEEDED(m_pQP->get_FramesDrawn(&tmp))
                         && SUCCEEDED(m_pQP->get_FramesDroppedInRenderer(&tmp1))) {
-                    info.Format(IDS_MAINFRM_6, tmp, tmp1);
-                } else {
-                    info = _T("-");
-                }
-                m_wndStatsBar.SetLine(StrRes(IDS_AG_FRAMES), info);
+                        info.Format(IDS_MAINFRM_6, tmp, tmp1);
+                    } else {
+                        info = _T("-");
+                    }
+                    m_wndStatsBar.SetLine(StrRes(IDS_AG_FRAMES), info);
 
-                if (SUCCEEDED(m_pQP->get_Jitter(&tmp))) {
-                    info.Format(_T("%d ms"), tmp);
+                    if (SUCCEEDED(m_pQP->get_Jitter(&tmp))) {
+                        info.Format(_T("%d ms"), tmp);
+                    } else {
+                        info = _T("-");
+                    }
+                    m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_JITTER), info);
                 } else {
-                    info = _T("-");
+                    m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_PLAYBACK_RATE), rate);
                 }
-                m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_JITTER), info);
-            } else {
-                m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_PLAYBACK_RATE), rate);
-            }
 
-            if (m_pBI) {
-                CString sInfo;
+                if (m_pBI) {
+                    CString sInfo;
 
-                for (int i = 0, j = m_pBI->GetCount(); i < j; i++) {
-                    int samples, size;
-                    if (S_OK == m_pBI->GetStatus(i, samples, size)) {
-                        sInfo.AppendFormat(_T("[%d]: %03d/%d KB "), i, samples, size / 1024);
+                    for (int i = 0, j = m_pBI->GetCount(); i < j; i++) {
+                        int samples, size;
+                        if (S_OK == m_pBI->GetStatus(i, samples, size)) {
+                            sInfo.AppendFormat(_T("[%d]: %03d/%d KB "), i, samples, size / 1024);
+                        }
                     }
-                }
 
-                if (!sInfo.IsEmpty()) {
-                    sInfo.AppendFormat(_T("(p%lu)"), m_pBI->GetPriority());
-                    m_wndStatsBar.SetLine(StrRes(IDS_AG_BUFFERS), sInfo);
+                    if (!sInfo.IsEmpty()) {
+                        sInfo.AppendFormat(_T("(p%lu)"), m_pBI->GetPriority());
+                        m_wndStatsBar.SetLine(StrRes(IDS_AG_BUFFERS), sInfo);
+                    }
                 }
-            }
 
-            {
-                // IBitRateInfo
-                CString sInfo;
-                BeginEnumFilters(m_pGB, pEF, pBF) {
-                    unsigned i = 0;
-                    BeginEnumPins(pBF, pEP, pPin) {
-                        if (CComQIPtr<IBitRateInfo> pBRI = pPin) {
-                            DWORD nAvg = pBRI->GetAverageBitRate() / 1000;
-
-                            if (nAvg > 0) {
-                                sInfo.AppendFormat(_T("[%u]: %lu/%lu kb/s "), i, nAvg, pBRI->GetCurrentBitRate() / 1000);
+                {
+                    // IBitRateInfo
+                    CString sInfo;
+                    BeginEnumFilters(m_pGB, pEF, pBF) {
+                        unsigned i = 0;
+                        BeginEnumPins(pBF, pEP, pPin) {
+                            if (CComQIPtr<IBitRateInfo> pBRI = pPin) {
+                                DWORD nAvg = pBRI->GetAverageBitRate() / 1000;
+
+                                if (nAvg > 0) {
+                                    sInfo.AppendFormat(_T("[%u]: %lu/%lu kb/s "), i, nAvg, pBRI->GetCurrentBitRate() / 1000);
+                                }
                             }
+                            i++;
                         }
-                        i++;
-                    }
-                    EndEnumPins;
+                        EndEnumPins;
 
-                    if (!sInfo.IsEmpty()) {
-                        m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_BITRATE), sInfo + ResStr(IDS_STATSBAR_BITRATE_AVG_CUR));
-                        sInfo.Empty();
+                        if (!sInfo.IsEmpty()) {
+                            m_wndStatsBar.SetLine(StrRes(IDS_STATSBAR_BITRATE), sInfo + ResStr(IDS_STATSBAR_BITRATE_AVG_CUR));
+                            sInfo.Empty();
+                        }
                     }
+                    EndEnumFilters;
                 }
-                EndEnumFilters;
             }
 
-            const CAppSettings& s = AfxGetAppSettings();
-
             if (GetPlaybackMode() == PM_DVD) { // we also use this timer to update the info panel for DVD playback
                 ULONG ulAvailable, ulCurrent;