-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two Small Problems - 2.1.4 #2482
Comments
Is it actually taller or is that just an artifact of the screenshot? |
One of screenshoot taken from compiled mpc-hc the other one is from vs2019 resource editor. Page size is same but maybe it is streching with pagetree view or just dpi(125%) issue. I might both take screenshoots from vs2019 but somehow I thought it looks narrowed for text spaces for clarity. |
@adipose Can you try my changes when you are available? After the adjustment there will be probably still some issues afaik these 3 languages (Bulgarian, Greek, Portuguese(Brazil)), there are some things that need to be checked, some of which should be done by the translators:
i.e.: Show chapter marks on seekbar can also translateble as Show chapter marks
Narrowing the font options box and expanding it according to the its content may solve the problem.
|
Is number two complete? For number 1, I don't quite understand what's wrong. Can you post some screenshots? I tried some other languages and they seem ok. |
1 is already taken care of. |
You will have to shorten the translations. Like remove "(SMTC)" part which is English abbreviation of the relevant Windows API. |
For hover type at least, I can enable dynamic sizing of the combo: |
I don't want to sound overly demanding, but I would like to add the followings, which I think is quite relevant to the issues. |
It can be improved. Comboboxes height cannot be controlled, but static height can, so I can make it close. Looks like combobox naturally has an extra pixel on the bottom in 175% mode. But by setting the static height to the closest possible, the text lines up when centered vertically. I'll review other forms and improve them. |
Considering the age of the MPC-HC, different design approaches have been applied in different times and places before. Maybe I may have accepted the one that appeals to my eyes as correct by being selective in perception. In the past, I have been unable to untangle several design complexities and have attempted small “improvements”, but a broader perspective and a comprehensive intervention would eventually be needed. Even though “Subtitles>Default Style” is on the same page, the size of the editboxes and even the distances between them are different. It seems like all this could be covered in a separate comprehensive “GUI Design” issue, but I think there is no need to rush into this yet. |
See #2815 for some dynamic alignment improvements. |
Hi, i ran into 2 small problems with mpc:
1 - The Inno installer is using a REALLY old translation of an OLD inno setup's version. I'm not referring to the strings we can find on transifex. Could you please update the Inno's version so it'll use the newest translations for all languages?
2 - I saw the GUI was expanded in the commits with the submission of a pull request but there are places where the translated strings cant be seen such as this one:
There are other places where i cant see the translated strings and i'm sure this happens with other languages too since languages other than english usually contain bigger words or phrases.
The text was updated successfully, but these errors were encountered: