Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo list for Audio statusbar info and IAMStreamSelect code changes #2640

Open
clsid2 opened this issue Mar 6, 2024 · 4 comments
Open

ToDo list for Audio statusbar info and IAMStreamSelect code changes #2640

clsid2 opened this issue Mar 6, 2024 · 4 comments

Comments

@clsid2
Copy link
Owner

clsid2 commented Mar 6, 2024

High priority:

  • When WM ASF Reader is used as source filter, then audio shows up as PCM. This is because upstream filters of AudioSwitcher does not implement IAMStreamSelect. AudioSwitcher in that case just uses mediatype of its own input pin. Should be changed to input pin of upstream decoder. See 5faa90a. WMA Sample
  • Test test test

Low priority:

  • Handle audio changes when done through splitter tray icon. Maybe let AudioSwitcher send a custom graph event on NewSegment? Then call function to update audio track info in case there are multiple tracks.
  • Audio info is shown even if track fails to connect to a decoder. Not sure if this can be prevented. Check if pin is connected?
    Sample

Not fixable:

  • If source filter is also a decoder, then audio format shows as PCM. For example with BassAudioSource.
@adipose
Copy link

adipose commented Mar 6, 2024

  • Handle audio changes when done through splitter tray icon.

Can we just use WM_TIMER? I believe DVD updates are already handled there.

@adipose
Copy link

adipose commented Mar 6, 2024

@clsid2
Copy link
Owner Author

clsid2 commented Mar 6, 2024

CMainFrame::OnTimer()
I want to avoid repeatedly running code to check if tracks were changed. Better to do it just if something has actually changed.

@clsid2
Copy link
Owner Author

clsid2 commented Mar 7, 2024

Can you test if DVB still works properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants