-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update node version #6789
base: main
Are you sure you want to change the base?
fix: Update node version #6789
Conversation
alexandersperling
commented
May 8, 2024
- Update node version to solve CVE-2024-21892
* Update node version to solve CVE-2024-21892
Thank you for the PR! This project just wraps the version used in VS Code, since that is the one that is tested and supported by them: https://github.com/microsoft/vscode/blob/main/remote/.yarnrc Once they have updated, we can as well. |
they now updated the version to 20.9.0, but this wont fix the CVE either... |
Oh weird I wonder why they chose to do that. Oh it probably matches whatever Node version is being used in Electron... |
I wonder if it should work with node https://github.com/microsoft/vscode/blob/main/.nvmrc You know why there are differences with the .yarnrc you linked before and the general node version used in the repo? |
I am not sure, that does seem weird. 🤔 |
@code-asher they now updated to 20.11.1 and so did I 😄 |
Awesome! We update VS Code on each release so we will need to wait until 1.90.0 or maybe 1.91.0. |