Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pykan recipe #26286

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add pykan recipe #26286

wants to merge 11 commits into from

Conversation

maxvolk
Copy link
Member

@maxvolk maxvolk commented May 8, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pykan) and found some lint.

Here's what I've got...

For recipes/pykan:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pykan) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pykan) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pykan:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

recipes/pykan/meta.yaml Outdated Show resolved Hide resolved
recipes/pykan/meta.yaml Outdated Show resolved Hide resolved
@maxvolk
Copy link
Member Author

maxvolk commented May 15, 2024

There seems to be no windows builds of pytorch on conda-forge right? (This PR indicates so.) This would explain why the windows build of this feedstock fails.

recipes/pykan/meta.yaml Outdated Show resolved Hide resolved
recipes/pykan/meta.yaml Outdated Show resolved Hide resolved
@maxvolk maxvolk marked this pull request as ready for review May 15, 2024 14:43
@maxvolk
Copy link
Member Author

maxvolk commented May 15, 2024

@conda-forge/help-python Can this be merged without the win_64 build working? pytorch is not available on windows.


requirements:
host:
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- python
- python >=3.7

Comment on lines +24 to +29
- matplotlib ==3.6.2
- numpy ==1.24.4
- scikit-learn ==1.1.3
- sympy ==1.11.1
- pytorch >=2.1.2
- tqdm ==4.66.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the package does import these, the metadata doesn't specify any of those nor those specific versions. Can you open an issue upstream? Also, please release the exact pins b/c that will make a nightmare to install this package in any environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants