Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransformerEngine #26296

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 9, 2024

A library for accelerating Transformer models on NVIDIA GPUs! Repo at https://github.com/NVIDIA/TransformerEngine

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (TransformerEngine) and found some lint.

Here's what I've got...

For TransformerEngine:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

A library for accelerating Transformer models on NVIDIA GPUs! Repo at https://github.com/NVIDIA/TransformerEngine
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/TransformerEngine) and found it was in an excellent condition.

@weiji14 weiji14 mentioned this pull request May 9, 2024
10 tasks
- pip
- python
run:
- flash-attn >=2.0.6,<=2.4.2,!=2.0.9,!=2.1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for NVIDIA/TransformerEngine#838 and a subsequent release, since conda-forge only has flash-attn=2.5.8 at the moment.

@weiji14
Copy link
Member Author

weiji14 commented May 15, 2024

So TransformerEngine v1.6 has a git submodule dependency on cudnn-frontend v1.3.0 (see https://github.com/NVIDIA/TransformerEngine/tree/v1.6/3rdparty). From reading conda-forge/conda-forge.github.io#619, it sounds like the proper way is to actually have a cudnn-frontend package on conda-forge and let transformer-engine depend on that, so opened #26370 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant