Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ml4xcube package #26342

Merged
merged 6 commits into from
May 16, 2024
Merged

add ml4xcube package #26342

merged 6 commits into from
May 16, 2024

Conversation

Julia310
Copy link
Contributor

@Julia310 Julia310 commented May 13, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ml4xcube) and found it was in an excellent condition.

@Julia310
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

- pip
run:
- python >=3.8
- conda-forge::xcube
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the :: in a package name preceded by the the channel (?). I think this could just be xcube. Could you clarify why the dependency is listed the way that it is?

Copy link
Contributor Author

@Julia310 Julia310 May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @synapticarbors

Thank you for reviewing my Python package!

I wanted to install xcube specifically from the conda-forge channel because the latest versions of this package are only available there.

As mentioned in this GitHub issue, the syntax channel::package can be used in an environment.yml file to force the installation from a specific channel. I assumed this would work in the meta.yaml as well, so I used this approach to ensure that the package is installed from conda-forge.

Since I am not shure if this is the right approach for meta.yaml I simply added a package version to the definition.

Thanks again for your review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On conda-forge we only pull from the conda-forge channel for requirements, and for end-users it's probably better to specify the correct version rather than trying to force a particular channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @synapticarbors,

Thank you for merging my code. I have been trying to find the ml4xcube package in the available conda-forge packages, but it seems it is not yet available for download. Could you please let me know when it will be possible to download it?

As I am new to this procedure, I would appreciate your feedback in this regard.

Best,
Julia

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedstock was created here https://github.com/conda-forge/ml4xcube-feedstock but it didn't actual build the packages for some reason. Let me look into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @synapticarbors,

I hope you're doing well. I wanted to follow up on the status of the ml4xcube package. Is there any update on why the package build didn't succeed. How could I proceed from here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conda-forge/ml4xcube-feedstock#2 (comment) -- one way to proceed would be to remove the pip check there which I can do

@synapticarbors synapticarbors merged commit da06caf into conda-forge:main May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants