-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openai-whisper #26360
base: main
Are you sure you want to change the base?
Add openai-whisper #26360
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/openai-whisper:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/openai-whisper:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/openai-whisper:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/openai-whisper:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/openai-whisper/meta.yaml
Outdated
- tiktoken | ||
- ffmpeg | ||
run_constrained: | ||
- triton >=2.0.0,<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the best way to add this. Currently, it looks like CUDA is the only support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it to the normal run and then we see what the logs say?
recipes/openai-whisper/meta.yaml
Outdated
- whisper=whisper.transcribe:cli | ||
script: {{ PYTHON }} -m pip install . -vv --no-deps | ||
number: 0 | ||
skip: true # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get this to build on Windows because of pytorch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a dependency is not available on a specific OS, we prefer to just let it fail instead of skipping it. Once the dependency becomes available, the package can be installed there as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions.
recipes/openai-whisper/meta.yaml
Outdated
- whisper=whisper.transcribe:cli | ||
script: {{ PYTHON }} -m pip install . -vv --no-deps | ||
number: 0 | ||
skip: true # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a dependency is not available on a specific OS, we prefer to just let it fail instead of skipping it. Once the dependency becomes available, the package can be installed there as well.
recipes/openai-whisper/meta.yaml
Outdated
- tiktoken | ||
- ffmpeg | ||
run_constrained: | ||
- triton >=2.0.0,<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it to the normal run and then we see what the logs say?
@BastianZim, I have updated with the requested changes. Both Linux and Windows failures are related to pytorch. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).