Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biome #26361

Merged
merged 5 commits into from
May 17, 2024
Merged

Add biome #26361

merged 5 commits into from
May 17, 2024

Conversation

AntoinePrv
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biome) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/biome:

@AntoinePrv AntoinePrv force-pushed the biome branch 3 times, most recently from 4b1dcf5 to 7bd19a3 Compare May 15, 2024 10:02
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biome) and found it was in an excellent condition.

@AntoinePrv AntoinePrv force-pushed the biome branch 2 times, most recently from 90ebbfe to 5931c09 Compare May 15, 2024 11:48
@AntoinePrv AntoinePrv force-pushed the biome branch 3 times, most recently from bb8560d to 7ddd727 Compare May 16, 2024 10:18
@AntoinePrv AntoinePrv marked this pull request as ready for review May 16, 2024 11:20
@AntoinePrv
Copy link
Contributor Author

@conda-forge/help-rust this is ready

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise lgtm

recipes/biome/conda-forge.yml Outdated Show resolved Hide resolved
@AntoinePrv AntoinePrv requested a review from xhochy May 17, 2024 17:31
@AntoinePrv
Copy link
Contributor Author

Thanks @xhochy ! All done now.

@xhochy xhochy merged commit dd7236e into conda-forge:main May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants