Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-netlib 0.12.0-final does not compile with C++17 gcc + libstdc++ #863

Open
germandiago opened this issue Nov 1, 2018 · 1 comment
Open

Comments

@germandiago
Copy link

Hello everyone,

OS: ubuntu 18.04 (dockerized)

There seems to be an ambiguity in make_optional calls due to ADL when compiling with gcc + libstdc++ as packaged in Ubuntu. For some reason std::make_optional is included indirectly in file uri_parts.hpp file. I tried to include cppnet headers before anything else but the problem persisted.

So I created a patch for explicit ::boost qualification in uri_parts.hpp. If there is any interest, please let me know, I will send a PR.

@deanberris
Copy link
Member

Yes, please send a PR -- you can assign it to me or to @glynos for review/merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants