Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why we always need bio_make_read_clone in snapshot mode? #357

Open
hongyuntw opened this issue Feb 21, 2024 · 0 comments
Open

Why we always need bio_make_read_clone in snapshot mode? #357

hongyuntw opened this issue Feb 21, 2024 · 0 comments

Comments

@hongyuntw
Copy link

hongyuntw commented Feb 21, 2024

Hello, I'd like to ask a question.

In snapshot mode, can we perform a check within the snap_trace_bio function before executing bio_make_read_clone? If the current bio is not a copy on "first" write (verified through COW mapping can do that), can we directly passthrough this bio without the need for an additional read clone, thus reducing one read IO overhead?

Do you think this idea is reasonable, or was there a specific reason why it wasn't initially designed this way? Because each read operation seems to be quite resource-intensive in snapshot mode.

I also noticed there was a related discussion before #282 , but it seems there hasn't been any follow-up.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant