Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create davebunte.md #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davebunte
Copy link

@davebunte davebunte commented Nov 17, 2022

馃摉 How does it feel to contribute to open source?

Pretty cool 馃槑!

馃挕 What did you learn?

  • Added two new VS Code plugins to my setup (and with it the ToC generation)
  • Side-by-side markdown/preview editing in VS code

馃憤 What worked well in this session?

  • Showed how to use VS Code + GitHub Desktop together
  • Basic Markdown syntax for folks that weren't familiar

馃搱 How could we improve this session?

  • It was a bit hard to keep up. You knew your favorite breakfasts, but I had to stop and think 馃.
  • Not having repo write permissions made some of the instructions a bit off (e.g. we needed to fork the repo and couldn't actually approve our partner's PR). I actually think this use model (fork to contribute) is a model our customers use (especially the open source ones) that we don't have as much exposure to internally. (We're spoiled on getting write permissions on :all-the-things:.) Rather than fixing the permissions issue, I would recommend updating the instructions to demonstrate that particular flow (contributing a PR to a repo where you don't have write permissions).

- Added link to davebunte
- Added Octocat image
- Additional Markdown syntax
@davebunte davebunte closed this Nov 17, 2022
@davebunte davebunte reopened this Nov 17, 2022
@davebunte davebunte marked this pull request as ready for review November 17, 2022 19:50
Copy link

@cmoorad cmoorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

contributions/davebunte.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants