Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include captures in parsed errors #124

Open
joshaber opened this issue Sep 13, 2017 · 1 comment
Open

Include captures in parsed errors #124

joshaber opened this issue Sep 13, 2017 · 1 comment

Comments

@joshaber
Copy link
Contributor

Some of our error regexes include captures, but they aren't actually passed up and out to consumers. We should do that, though it'll require some refactoring of errors.

@shiftkey
Copy link
Member

Seems legit. Probably a breaking change to the API as parseError is only returning an enum currently:

public static parseError(stderr: string): GitError | null {
  // ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants