Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: eslint integration #553

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build: eslint integration #553

wants to merge 4 commits into from

Conversation

LeoDog896
Copy link

@LeoDog896 LeoDog896 commented Aug 2, 2023

This adds the eslint toolchain to the repository, based on the config used in desktop/desktop.

I wanted to avoid breaking changes in this PR, but there are a few notable problems:

  • eslint noticed an odd static class wrapper in git-process.ts that can easily be replaced with a collection of exported static methods
  • The no-namespace rule had to be disabled to satisfy the Jest extension config - there is a notable comment under this StackOverflow post about this issue (I may look into this later)
  • Since I've taken the config directly from desktop/desktop (while dropping react), there are probably a few rules that can be removed.

Copy link

@Presidentialjaygolden35 Presidentialjaygolden35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants