drop support for python 2 and add some typing #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given it's been EOL for a year now it's probably time. I would just want to bump a major version. |
|
Bumped the major version number to 5 and updated the docs! |
fuhrysteve
force-pushed
the
bye-python-2-hello-typing
branch
from
f84bed9
to
1f401e8
Compare
fuhrysteve
force-pushed
the
bye-python-2-hello-typing
branch
from
1f401e8
to
86de07e
Compare
fuhrysteve
force-pushed
the
bye-python-2-hello-typing
branch
from
56a570b
to
a1af3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're open to dropping python 2 support, but I thought I'd test the waters!
Nothing too exciting, just adding typing on the user-facing
zxcvbn()function and in a couple other super easy places, if only to make sure mypy & github actions are actually working.Please note that this fully breaks backward compatibility with python 3.5 or lower, as it uses features introduced in python 3.6.