Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert heading challenge test to Playwright #54880

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 20, 2024

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 20, 2024
@Sembauke Sembauke marked this pull request as ready for review May 20, 2024 16:24
@Sembauke Sembauke requested a review from a team as a code owner May 20, 2024 16:24
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@Sembauke Sembauke mentioned this pull request May 21, 2024
61 tasks
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include the Cypress file deletion in this PR, too?

Comment on lines +15 to +17
expect(response?.request().redirectedFrom()?.redirectedTo()?.url()).toContain(
expectedPath
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify the test with:

await page.goto('this-page')

await page.waitForURL('that-page')
await expect(page.getByRole('heading', { name: 'Title of that page' })).toBeVisible()

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency, I think we should go with

      await page.goto(input);
      await expect(page).toHaveURL(new RegExp(`${expected}/?`));

@huyenltnguyen huyenltnguyen added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 22, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 22, 2024
@Sembauke
Copy link
Member Author

Sembauke commented May 23, 2024

I am going to block this one as #54897 does the same thing and I want to merge it in to that spec file.

@Sembauke Sembauke added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 23, 2024
@Sembauke Sembauke closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants