Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): add a preview page to pyramid project #54885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a2937
Copy link
Member

@a2937 a2937 commented May 20, 2024

Checklist:

Closes #54801

A new step 1 was created that explains what Javascript is and what the project is about. The old step 2 was also modified such that it didn't repeat itself on what Javascript was. The other challenges just had their numbers updated.

@a2937 a2937 requested a review from a team as a code owner May 20, 2024 17:44
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 20, 2024
@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP new javascript course These are for issues dealing with the new JS curriculum labels May 22, 2024
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍(fix the merge conflicts if you get any)

@a2937 a2937 requested a review from a team as a code owner May 23, 2024 19:18
@camperbot
Copy link
Contributor

Thanks for your pull request.

Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed.

We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages.

Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

@a2937
Copy link
Member Author

a2937 commented May 23, 2024

I think I merged it wrong.

@github-actions github-actions bot added platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels May 23, 2024
@a2937 a2937 force-pushed the feat(curriculum)/add-preview-step-pyramid branch from cef11c3 to 8a50624 Compare May 23, 2024 19:21
@github-actions github-actions bot removed platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels May 23, 2024
@a2937 a2937 force-pushed the feat(curriculum)/add-preview-step-pyramid branch from 8a50624 to a549a1f Compare May 23, 2024 19:45
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Worst case scenario, the camper tries to write more code or something. Test will pass regardless.

@a2937
Copy link
Member Author

a2937 commented May 31, 2024

I think I need to rebase this, again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new step 1 to better explain what the pyramid generator is about
6 participants