Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button should be highlighted if aria-expanded="true" #12

Open
huyenltnguyen opened this issue Dec 20, 2023 · 0 comments
Open

Button should be highlighted if aria-expanded="true" #12

huyenltnguyen opened this issue Dec 20, 2023 · 0 comments
Assignees
@huyenltnguyen
Labels
type: bug Something isn't working

Comments

@huyenltnguyen
Copy link
Member

Describe the bug

The Button component in ui-components should be highlighted if aria-expanded="true". This will enable the migration of native button to ui-components Button.

However, this change will impact the display of Dropdown so we need to revisit the UI of this component as well.

Dropdown with aria-expanded="false" Dropdown with aria-expanded="true"
Screenshot 2023-12-20 at 16 57 01 Screenshot 2023-12-20 at 16 56 45

Additional context

Related to freeCodeCamp/freeCodeCamp#52641.
@huyenltnguyen huyenltnguyen mentioned this issue Jan 8, 2024
Closed
@raisedadead raisedadead transferred this issue from freeCodeCamp/freeCodeCamp Apr 4, 2024
@huyenltnguyen huyenltnguyen changed the title [UI Components] Button should be highlighted if aria-expanded="true" Button should be highlighted if aria-expanded="true" Apr 5, 2024
@huyenltnguyen huyenltnguyen self-assigned this Apr 5, 2024
@huyenltnguyen huyenltnguyen added the type: bug Something isn't working label Apr 5, 2024
@huyenltnguyen huyenltnguyen mentioned this issue May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huyenltnguyen huyenltnguyen

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huyenltnguyen