Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the ui components #23

Open
6 tasks
Sboonny opened this issue Sep 26, 2023 · 5 comments
Open
6 tasks

Rework the ui components #23

Sboonny opened this issue Sep 26, 2023 · 5 comments
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@Sboonny
Copy link
Member

Sboonny commented Sep 26, 2023

There are abstractions used in the current codebase, which are duplicated in the ui-components library, or old design desicions that can be easily altered for better styles:

  • Button can be a link and a button at the same time.
  • FormControl can be textarea and input at the same time.
  • The needs to add specific properties to have presentable layout, more discussion can be found here refactor: replace Col component freeCodeCamp#51322
  • using shadow-box instead of border for Panel component Removal of the Panel component of our codebase freeCodeCamp#48790
  • Change the color of the Button Component
  • maybe delete image component for an eslint rule that can do what it currently do, or add styles that make the images stay consistent between browser sizing block w-full h-full

These topics should be discussed after the ui-components are imported and bootstrap is removed.

@ianujvarshney

This comment was marked as off-topic.

@subhro1530

This comment was marked as off-topic.

@rahulrana701

This comment was marked as off-topic.

@stgeer

This comment was marked as off-topic.

@Sboonny
Copy link
Member Author

Sboonny commented Sep 29, 2023

Thank you @ianujvarshney, @stgeer, @subhro1530, and @rahulrana701 for you eagerness to help. but as mentioned in the issue, the implementation will be discussed after bootstrap is removed, I encourge you to look at help wanted issues.

@freeCodeCamp freeCodeCamp locked as too heated and limited conversation to collaborators Sep 29, 2023
@freeCodeCamp freeCodeCamp unlocked this conversation Apr 5, 2024
@Sembauke Sembauke transferred this issue from freeCodeCamp/freeCodeCamp Apr 5, 2024
@huyenltnguyen huyenltnguyen added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

6 participants