Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge (Chromium) fix to prevent popup spinner hang #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marknoble
Copy link

@marknoble marknoble commented Feb 17, 2021

Addresses an issue as part of Issue #7 (comment) where spinner is perpetually displayed due to an error.

Change addresses the spinner issue by replacing "browser" with "chrome" as discussed here: https://stackoverflow.com/questions/63825136/ms-edge-api-error-browser-is-not-defined

Changed value on Edge (Chromium) Version 90.0.789.1 (Official build) dev (64-bit) where I have Dissenter plugin installed and it addressed the issue with hanging on the spinner pop-up.

Addresses an issue as part of Issue gab-ai-inc#7 (gab-ai-inc#7 (comment)) where spinner is perpetually displayed due to an error.

Change addresses the spinner issue by replacing "browser" with "chrome" as discussed here: https://stackoverflow.com/questions/63825136/ms-edge-api-error-browser-is-not-defined

Changed value on Edge (Chromium) Version 90.0.789.1 (Official build) dev (64-bit) where I have Dissenter plugin installed and it addressed the issue with hanging on the spinner pop-up.
@marknoble
Copy link
Author

Forked this to offer a fixed version for Edge (Chromium).

https://github.com/marknoble/gab-dissenter-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant