Graph zoom fix #137
Closed
Graph zoom fix #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoelj
requested changes
Aug 7, 2023
views/user/authorized_index.ejs
Outdated
Comment on lines
3666
to
3674
| let allDates = []; | ||
| for (let data of chartData) { | ||
| if (data && data.assignmentDates) { | ||
| allDates = allDates.concat(data.assignmentDates); | ||
| } | ||
| } | ||
| allDates = allDates.map(dateStr => new Date(dateStr)); | ||
| const earliestDate = new Date(Math.min(...allDates)); | ||
| const latestDate = new Date(Math.max(...allDates)); |
There was a problem hiding this comment.
Is there a reason to calculate these instead of using the startDate and endDate variables that exist in this scope? Also, use spaces not tabs.
There was a problem hiding this comment.
didn't use it cause there's like almost 5000 lines and I wasn't gonna read through all that so I never found those variables, but I can change it
views/user/authorized_index.ejs
Outdated
| } | ||
| }, limits: { | ||
| xAxis: {min: earliestDate, max: latestDate}, | ||
| yAxis: {min: 0, max: 100} |
There was a problem hiding this comment.
How does this react to extra credit that brings someone's grade above 100?
views/user/authorized_index.ejs
Outdated
Comment on lines
3820
to
3822
| xAxis: {min: earliestDate, max: latestDate}, | ||
| yAxis: {min: 0, max: 100} | ||
| } |
tatertotbot
force-pushed
the
development
branch
from
b8f7b7f
to
0f59d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph cannot be zoomed out farther than 0-100 on the y axis and the date of the first and last assignment for the x axis.
Also, suggestedMax was changed to 100 rather than 110 to fit into this zoom restriction.
Note: this is only for the main graph because I don't have any data for specific classes and I would rather not mess anything up, but rather do this first.