Lock zoom box #178
Open
Lock zoom box #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will prevent someone from zooming out into the abyss
accidentally left this in
|
fixes #134 |
jjoelj
requested changes
Jan 26, 2024
| @@ -4364,6 +4375,14 @@ | |||
| } | |||
| } | |||
| }); | |||
| //sets the zoom and pan limits for the individual class graphs | |||
| charts[id+1].options.plugins.zoom.limits = { | |||
| xAxis: {min: minDate, max: maxDate}, | |||
There was a problem hiding this comment.
Do you define minDate and maxDate anywhere in this function?
There was a problem hiding this comment.
lines 4159 and 4160
Those lines are in a different function and the variables appear to be implicitly declared, which is not good practice. If you intend for them to be global variables, you should explicitly declare them using let in the global scope.
jjoelj
requested changes
Jan 29, 2024
Comment on lines
+3890
to
+3891
| let maxDate = Infinity; | ||
| let minDate = Infinity; |
There was a problem hiding this comment.
These declarations are still only in the scope of renderOverviewChart(). Also, can you explain your rationale for initializing these to Infinity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent someone from zooming out into the abyss