Multiple highlights #512
Open
Multiple highlights #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to include these before/after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue (I'll link the report later) identified with the area highlights. Each highlight darkens the entire area around it, including other highlight areas. This means that if the user places multiple highlight areas, they all get progressively darker and blurrier.
My fix just passes the locations of other highlight areas in when we draw one of them so each can be excluded from the filters. Not incredibly efficient but I can't see users having any more than 3-4 of these, so the effect should be super minimal, otherwise I'd have done it differently. For some reason this operation is very slow to begin with, which might be worth looking into at some point.
Feedback is welcome!