Allow to write state using compact representation #35175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to write JSON using compact (non-indented) representation if the `TF_USE_COMPACT_STATE_FORMAT` environment variable is defined. This significantly improves performance when working with huge states. For example (on ~450k objects in state): * state size is decreased from 510.1MB to 386.6MB * Time to write to S3 decreased from 112 seconds to 94 seconds * Time to read from S3 decreased from 87 seconds -> 55 seconds Fixes hashicorp#35174 Signed-off-by: Alex Ott <alexott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to write JSON using compact (non-indented) representation if the
TF_USE_COMPACT_STATE_FORMATenvironment variable is defined. This significantly improves performance when working with huge states.For example (on ~450k objects in the state):
Fixes #35174
Target Release
1.8.x
Draft CHANGELOG entry
NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS