Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Change Vega Data Node #6958

Open
david-hummingbot opened this issue Apr 8, 2024 · 5 comments
Open

Feature Request - Change Vega Data Node #6958

david-hummingbot opened this issue Apr 8, 2024 · 5 comments
Labels
enhancement Upgrade or improvement to an existing hummingbot feature

Comments

@david-hummingbot
Copy link
Contributor

david-hummingbot commented Apr 8, 2024

Feature Suggestion

Introduce a feature enabling users to designate their preference for utilizing either public or private nodes for the vega_perpetual connector. During the configuration process of the connector, the following steps will be undertaken:

  1. Request the input of connect API keys.
  2. Prompt the user to indicate their preference for utilizing public or private nodes (Y/N):
    • If yes, prompt for the adding the endpoint.
    • If no, default to public nodes and proceed to complete the setup

Impact

Improve trading performance on Vega

Additional context

No response

@david-hummingbot david-hummingbot added the enhancement Upgrade or improvement to an existing hummingbot feature label Apr 8, 2024
@david-hummingbot
Copy link
Contributor Author

Hi @R-K-H, we have a private data node up and running and planning to do some testing to see if it improves performance on Vega. If the IP address of our data node server is "13.122.55.253" do we just change the hardcoded values in the following places? Is there anywhere else we need to change it or other values needed to be made in order for it to work? Appreciate your help on this!

image

@R-K-H
Copy link
Contributor

R-K-H commented Apr 8, 2024

If I recall, that is all that is required to ensure you use only your node. As long as your GPRC is serving from the same port as listed in there, you should be good. If you change it and it does not work, ping again with the error and I'll check.

@R-K-H
Copy link
Contributor

R-K-H commented Apr 8, 2024

The application makes an attempt to determine lowest ping, but this should result in only that one being selected. Perhaps adding it to the config for the exchange connector is of value, and if it's set and valid (not clear how validation would work right this second) then it would be exclusively utilized.

Let me know if you run into issues with the values there and given this is permissionless node operations it may merit the addition, we just didn't run our own node so didn't think to add it.

@david-hummingbot
Copy link
Contributor Author

Thanks, we ran into some issues initially but we'll retest and will let you know the results.

@R-K-H
Copy link
Contributor

R-K-H commented Apr 9, 2024

Given that you have the REST and GRPC on the same port, you likely need to check the node config to ensure that's acceptable (I don't think it is unless you're using a proxy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Upgrade or improvement to an existing hummingbot feature
Projects
None yet
Development

No branches or pull requests

2 participants