-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Improved the Injective Delegation Script #6905
base: development
Are you sure you want to change the base?
(feat) Improved the Injective Delegation Script #6905
Conversation
sync / staging -> master for Hummingbot version 1.24.0
sync mexc fix development to staging version 1.25.0
sync / staging -> master for Hummingbot version 1.25.0
hi @peterwilli , thank you for submitting PR, fyi, it should be aimed to development, I changed it for now https://hummingbot.org/developers/contributions/#checklist |
Yeah I saw, sorry I missed that, I will make sure to switch to development next time |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
With this change, you can use the delegation script without any modifications as it uses
argparse
to supply the parameters.In addition to
argparse
, the script now also takes both a private key and seed phrase, without showing it on screen (no echo). This improves security (when someone is looking over your shoulder).Also, deprecated functions have been replaced by up-to-date PyInjective functions. We might have to update the dependency in the docker container, though. I will make a separate PR for this.
Current usage:
Tests performed by the developer:
Tested the script with my test trading account (Call was
python hummingbot/connector/exchange/injective_v2/account_delegation_script.py --grantee_address inj1wdgalm0ygdcs4235gw7gqcwzsflpvaqfdq82tj --derivative_market_ids=0x18b2ca44b3d20a3b87c87d3765669b09b73b5e900693896c08394c70e79ab1e7 --grant_expiration_days 1
): https://www.mintscan.io/injective/tx/9D310898642A5270FF969FC537180FD95E41FD60F391AA9A91B8632C5F890773Tips for QA testing: