Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ispcrt tests installation #2484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nurmukhametov
Copy link
Collaborator

Do not install ispcrt tests into build directory

Also add ispcrt-tests component target which install ispcrt_mock_tests with dependent libraries. This component install target is excluded from ALL target. It may be installed by command:

cmake --install <dir> --component ispcrt-tests

Also add ispcrt-tests component target which install ispcrt_mock_tests
with dependent libraries. This component install target is excluded from
ALL target. It may be installed by command:

    cmake --install <dir> --component ispcrt-tests
@nurmukhametov
Copy link
Collaborator Author

It fixes #2482

@dbabokin dbabokin requested a review from aneshlya April 14, 2023 23:02
@aneshlya
Copy link
Collaborator

If we enable tests as part of the build, we should install them.
The option to disable tests is ISPCRT_BUILD_TESTS. It can be OFF by default. But if it's ON, I prefer not to run additional commands to install tests which are already built.

@pbrubaker
Copy link
Collaborator

Hey all, where do we stand on this issue?

@nurmukhametov
Copy link
Collaborator Author

Hey all, where do we stand on this issue?

My opinion is that there is no point in installing tests anywhere. Even if we do so, we need to install them at least under CMAKE_INSTALL_PREFIX, not inside build directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants