Miscellaneous fixes

[nurmukhametov]

This fixes build-related issue #2847

It fixes ispc-opt to check that provided pass name is correct.

[aneshlya]

This change is not equivalent to what was before. What about tinfo library in case of dynamic linking?
Even if it works in our environment I recommend double check it. There was an issue related to that.

[nurmukhametov]

Right. I have changed this to follow the LLVM logic here

[aneshlya]

Has the set of link libraries changed for release package or stayed the same as it was?

[nurmukhametov]

The release package used and uses the path under ISPC_STATIC_LINK. So, the find_package(Curses REQUIRED) and the following logic has never used in the release build. The set of linked libraries hasn't changed.

[dbabokin]

What libs do we need to be able to print output in terminal in different colors and detect terminal width (--no-wrap disables that)?

[nurmukhametov]

What libs do we need to be able to print output in terminal in different colors and detect terminal width (--no-wrap disables that)?

ISPC uses none libraries to do that. See here

ispc/src/util.cpp

Line 68 in 0f2b9fa

int ispc::TerminalWidth() {

and here

ispc/src/util.cpp

Line 87 in 0f2b9fa

static bool lHaveANSIColors() {

Given that it looks like the ncurses dependency is obsolete (#2855).

[dbabokin]

Given that it looks like the ncurses dependency is obsolete (#2855).

Thanks for explaining this. If we can drop this dependency, we should probably do that. But we need to make sure that output works as it used to be.

[dbabokin]

Why removing tinfo only for LLVM 18.0+? It makes the logic more complex - i.e it's ISPC version * LLVM version, rather than just ISPC version.

[nurmukhametov]

Why removing tinfo only for LLVM 18.0+? It makes the logic more complex - i.e it's ISPC version * LLVM version, rather than just ISPC version.

Because I don't want to rebuild the previous versions.

[dbabokin]

Because I don't want to rebuild the previous versions.

Up to you, but I vote for removing it once and for all versions - so we get better testing, less problems explaining different requirements when others are building ISPC and simpler code.