Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a Toast on Copy button too #319

Open
XhmikosR opened this issue Sep 24, 2021 · 4 comments
Open

Show a Toast on Copy button too #319

XhmikosR opened this issue Sep 24, 2021 · 4 comments

Comments

@XhmikosR
Copy link
Collaborator

While using Ctrl+C shows a Toast success message, when using the floating copy button there's no feedback.

It would probably make sense to streamline this.

@BarokDG
Copy link

BarokDG commented Nov 1, 2022

Can I help with this? It doesn't look like it's implemented.

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Nov 2, 2022

Since it's not implemented, generally, there's no need to ask, just go ahead and propose a PR :)

@BarokDG
Copy link

BarokDG commented Nov 3, 2022

Okay, my bad. Thanks!

I've been working on it for a while today but I can't find a good solution. The CopyButton class doesn't have access to the toastsUi since the toastsUi is initialised inside main-controller.js. I can try to create a tooltip instead tho. What do you think?

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Nov 3, 2022

Yeah, that was my problem when I had a quick look at it. Not sure if it's worth changing too much code to support this, but it's an inconsistency nonetheless.

@jakearchibald WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants