Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit setTimeout usage/JS animations #332

Open
XhmikosR opened this issue Sep 29, 2021 · 0 comments
Open

Revisit setTimeout usage/JS animations #332

XhmikosR opened this issue Sep 29, 2021 · 0 comments
Labels
enhancement help wanted

Comments

@XhmikosR
Copy link
Collaborator

XhmikosR commented Sep 29, 2021 •
edited

There are known performance issues with setTimeout. IIRC requestAnimationFrame should behave better.

I notice junky settings checkboxes animation on Firefox for Android when Power Saving is enabled on the device. Not sure it's related, but it would probably be better to use rAF anyway?

EDIT: we are also using offsetLeft is ripple. Not sure if there's a better way to do the same thing nowadays.
@XhmikosR XhmikosR changed the title Revisit setTimeout usage Revisit setTimeout usage/JS animations Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XhmikosR