Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic closing of the positions at the end of the simulation #343

Open
gaborvecsei opened this issue May 5, 2021 · 3 comments · May be fixed by #393
Open

Automatic closing of the positions at the end of the simulation #343

gaborvecsei opened this issue May 5, 2021 · 3 comments · May be fixed by #393
Labels
enhancement New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@gaborvecsei
Copy link

This is just a question about whats in the title.

  • Why is the framework closing the positions automatically at the end of the simulation?
  • Is there any way to prevent that?
@kernc
Copy link
Owner

kernc commented May 5, 2021 •
edited

Why is the framework closing the positions automatically at the end of the simulation?

So the trades can produce some stats. See #183, f77786e.

@gaborvecsei
Copy link
Author

So the trades can produce some stats. See #183, f77786e.

I understand that the unclosed trades wouldn't appearing in the final stats but that could be also a stat. E.g.:

  • still open positions
  • allocated money in those positions
  • return should be calculated only for the closed positions

Maybe a parameter like autoclose_open_positions in bt.run() would be useful, so people can decide if they want the feature or not.

I raised this question because the still open positions is also a good measure of a strategy. If the strategy fails to close the positions, this auto-closing can give the false feeling that the Strategy is working fine.

@kernc kernc added the enhancement New feature or request label May 6, 2021
@kernc kernc mentioned this issue May 8, 2021
Closed
@Benouare Benouare mentioned this issue May 23, 2021
Closed
Benouare added a commit to Benouare/backtesting.py that referenced this issue Jun 21, 2021
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
5852a76 
…kernc#343)
Benouare added a commit to Benouare/backtesting.py that referenced this issue Jun 21, 2021
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
021e274 
…kernc#343)
Benouare added a commit to Benouare/backtesting.py that referenced this issue Jun 21, 2021
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
60f5cfb 
…kernc#343)
@kernc kernc linked a pull request Jun 23, 2021 that will close this issue
Open
Benouare added a commit to Benouare/backtesting.py that referenced this issue Jun 23, 2021
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
4f8dcc7 
…kernc#343)
Benouare added a commit to Benouare/backtesting.py that referenced this issue Jun 23, 2021
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
3971535 
…kernc#343)
@kernc kernc added the Hacktoberfest https://hacktoberfest.digitalocean.com label Oct 7, 2021
@replacementAI
Copy link

Still able to see open trades that are closed because they are the last ones.

@kernc kernc mentioned this issue Feb 21, 2022
Closed
Benouare added a commit to Benouare/backtesting.py that referenced this issue May 15, 2023
@Benouare
ENH: Add the possibility to close trades at end of bt.run (kernc#273 & …
457c814 
…kernc#343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add the possibility to close trades at end of bt.run (#273 & #343) Benouare/backtesting.py
3 participants
@kernc @gaborvecsei @replacementAI