Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added live trading support #1009

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added live trading support #1009

wants to merge 4 commits into from
+649 −1

Conversation

ypogorelova
Copy link

Closes #81 Please see live_trading.py for usage examples

@Morakhiyasaiyam
Copy link

Morakhiyasaiyam commented Aug 10, 2023 •
edited

Hey how to implement other broker ? Can you make documentation upon it ?

@celikcedev
Copy link

Hey how to implement other broker ? Can you make documentation upon it ?

@ypogorelova
Copy link
Author

Hi! Actually subscribe_to_bar_events method from broker.py is based on Binance API: https://binance-docs.github.io/apidocs/spot/en/#kline-candlestick-streams. Please make sure to change URLs in env file accordingly

@wishabhilash
Copy link

Any plans of merging this???

@JustinGuese
Copy link

nice feature, but some docs would be nice, as its currently only working with coinbase right ;)? so maybe a quick readme on how to add other brokers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wishabhilash wishabhilash wishabhilash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Live trading support
5 participants
@ypogorelova @Morakhiyasaiyam @celikcedev @wishabhilash @JustinGuese