Skip to content
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.

App builder #11512

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

App builder #11512

wants to merge 5 commits into from

Conversation

Fress10
Copy link

@Fress10 Fress10 commented Dec 10, 2018

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR makes it possible to modify the koding user,
that is running the Klient service on a remote vm.

In particular the following user_data will currently
make the template parsing to fail:

    user_data: |
      #cloud-config
      users:
      - name: ${var.koding_account_profile_nickname}
        groups:
        - docker

This PR will merge the koding user object with the
default one, defined by kloud. In effect, the resulting
user will be added to a docker group as well.

This technique can be also used e.g. to add an ssh key
for the koding user, like:

    user_data: |
      #cloud-config
      users:
      - name: ${var.koding_account_profile_nickname}
        ssh-authorized-keys:
        - ssh-rsa AAAAB3NzaC1yc2EA... koding-350298856
A "userdata" is a JSONPath which allows for locating
a user_data (cloud-init) key within a stack template tree.

Locating cloud-init in the tree is going to allow for
provider-agnostic manipulation of stack template content,
like creating new and custom templates on-the-fly (as oppose
to dummy templates received from JTemplate.Sample).

The templates are meant to be manipulated client-side (e.g. kd),
before sending them over to koding.
Allows for disabling metrics with:

    $ kd config set noMetrics true

Works around #11201.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants