Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 #124969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 #124969

wants to merge 1 commit into from
+28 −205

Conversation

RomanBednar
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

PersistentVolumeLastPhaseTransitionTime feature is stable and enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3762

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/code-generation area/test labels May 20, 2024
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 20, 2024
@RomanBednar RomanBednar mentioned this pull request May 20, 2024
Open
12 tasks
@RomanBednar RomanBednar changed the title graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 KEP-3762: graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 May 20, 2024
@RomanBednar RomanBednar changed the title KEP-3762: graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 graduate PersistentVolumeLastPhaseTransitionTime to GA in 1.31 May 20, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@seans3
Copy link
Contributor

seans3 commented May 21, 2024

/triage accepted (for SIG api-machinery)

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

@seans3: The label(s) triage/(for, triage/sig, triage/api-machinery) cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted (for SIG api-machinery)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 21, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request May 23, 2024
Open
@jsafrane
Copy link
Member

Cross-linking the feature, kubernetes/enhancements#3762

@jsafrane
Copy link
Member

/lgtm
/approve
from storage POV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba77dfd8a57b3ab1218508d425e6bf7d862d3320

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, RomanBednar
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@jsafrane jsafrane

Labels
area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RomanBednar @k8s-triage-robot @seans3 @k8s-ci-robot @jsafrane