Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volumezone: scheduler queueing hints: pv #125001

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

volumezone: scheduler queueing hints: pv #125001

wants to merge 7 commits into from
+203 −25

Conversation

Gekko0114
Copy link
Member

@Gekko0114 Gekko0114 commented May 20, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added scheduler queueing hints to volume zone plugin.
This PR covers pv.

I divided #119373 into following 4 PRs.
#125000
#125001
#124996
#124998

Which issue(s) this PR fixes:

Part of #118893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler implements scheduling hints for the VolumeZone plugin.
The scheduling hints allow the scheduler to only retry scheduling a Pod
that was previously rejected by the VolemeZone plugin if  addition/update of node, 
addition/update of PV, addition/update of PVC, or addition of SC matches pod's topology settings.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2024
@Gekko0114
Copy link
Member Author

/assign @sanposhiho

@Gekko0114 Gekko0114 mentioned this pull request May 20, 2024
Open
12 tasks
This was referenced May 29, 2024
Open
Open
Closed
@Gekko0114
Copy link
Member Author

/assign @msau42
/assign @xing-yang

@sanposhiho
Copy link
Member

/retest
/cc @carlory

@k8s-ci-robot k8s-ci-robot requested a review from carlory May 31, 2024 06:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gekko0114
Once this PR has been reviewed and has the lgtm label, please ask for approval from msau42. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Gekko0114
Gekko0114 commented Jun 3, 2024
View reviewed changes
pkg/scheduler/framework/plugins/volumezone/volume_zone_test.go
},
}

testcases := map[string]struct {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@gnufied gnufied Awaiting requested review from gnufied

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@carlory carlory Awaiting requested review from carlory

Assignees

@xing-yang xing-yang

@msau42 msau42

@sanposhiho sanposhiho

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gekko0114 @k8s-ci-robot @sanposhiho @xing-yang @msau42