Wait for volume to be detached before taking a snapshot in e2e tests #125007
+54
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
amacaskill
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
amacaskill
force-pushed
the
fix-snapshot-tests
branch
2 times, most recently
from
9a5498a
to
347953f
Compare
k8s-ci-robot
added
size/M
amacaskill
force-pushed
the
fix-snapshot-tests
branch
2 times, most recently
from
c36065e
to
83e1615
Compare
k8s-ci-robot
added
the
area/e2e-test-framework
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amacaskill The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amacaskill
force-pushed
the
fix-snapshot-tests
branch
from
83e1615
to
3104a83
Compare
|
/test pull-kubernetes-unit |
amacaskill
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
amacaskill
force-pushed
the
fix-snapshot-tests
branch
2 times, most recently
from
caf8197
to
79d8e81
Compare
amacaskill
force-pushed
the
fix-snapshot-tests
branch
2 times, most recently
from
904177b
to
9bb4bf8
Compare
|
/test pull-kubernetes-e2e-gce-storage-snapshot |
msau42
reviewed
May 22, 2024
amacaskill
force-pushed
the
fix-snapshot-tests
branch
3 times, most recently
from
69bfcdc
to
940424a
Compare
msau42
reviewed
May 23, 2024
amacaskill
force-pushed
the
fix-snapshot-tests
branch
2 times, most recently
from
1487fe4
to
45308ad
Compare
amacaskill
force-pushed
the
fix-snapshot-tests
branch
from
45308ad
to
7e4f25c
Compare
|
/test pull-kubernetes-node-e2e-containerd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The VolumeSnapshotDataSource tests for the GCE PD Driver are flaky. They occasionally fail because of a race condition between detaching the disk and taking a snapshot. If a disk detaches while taking a snapshot, GCE will error with "Disk attachment changed while trying to make a snapshot." To fix, we should wait for the disk to be detached before taking the snapshot.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: