Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge Mesh!! #1

Closed
loboazul666 opened this issue Dec 6, 2023 · 16 comments
Closed

Huge Mesh!! #1

loboazul666 opened this issue Dec 6, 2023 · 16 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@loboazul666
Copy link

Pretty good script but it has an issue when you try to save games that has meshes
image (8)

@ActualMasterOogway
Copy link

definetly needs to be fixed ASAP, experienced the same issue, im using Hydrogen MacOS

@gamersindo1223
Copy link

Btw what exec r u guys using,

@phoriah
Copy link
Contributor

phoriah commented Mar 21, 2024

Sorry for late reply, will be looked into!

@phoriah
Copy link
Contributor

phoriah commented Mar 21, 2024

@loboazul666
@ActualMasterOogway Can you send game link(s)?

@phoriah phoriah added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Mar 21, 2024
@ActualMasterOogway
Copy link

@phoriah
Copy link
Contributor

phoriah commented Mar 23, 2024

Should be fixed in 4559e23
Needs to be tested & confirmed though.
@loboazul666 @ActualMasterOogway

@phoriah phoriah reopened this Mar 23, 2024
@Eetblgb25
Copy link

meshes still broken

@ActualMasterOogway
Copy link

Should be fixed in 4559e23 Needs to be tested & confirmed though. @loboazul666 @ActualMasterOogway

Works now, but i have an issue with the beams not being at the position they are supposed to, also i think the size of that beam is smaller

@phoriah
Copy link
Contributor

phoriah commented Mar 23, 2024

meshes still broken

Which executor are you using?

@phoriah
Copy link
Contributor

phoriah commented Mar 23, 2024

Should be fixed in 4559e23 Needs to be tested & confirmed though. @loboazul666 @ActualMasterOogway

Works now, but i have an issue with the beams not being at the position they are supposed to, also i think the size of that beam is smaller

Can you create a separate issue with more details, please?

@Eetblgb25
Copy link

meshes still broken

Which executor are you using?

hydrogen

@phoriah
Copy link
Contributor

phoriah commented Mar 23, 2024

meshes still broken

Which executor are you using?

hydrogen

Android or mac?

@phoriah
Copy link
Contributor

phoriah commented Mar 28, 2024

Happens due to InitialSize not being saved properly btw. Depends pretty much on the executor (whether it can read this hidden/special property or not)
Here is a script for testing whether Terrain/Meshes/Unions will work on your executor (Open F9 Console after executing)

local Sep = string.rep("-", 10)
warn(Sep .. "START" .. Sep)
local Terrain = workspace.Terrain
local MeshPart = game:FindFirstChildWhichIsA("MeshPart", true)
local UnionOperation = game:FindFirstChildWhichIsA("UnionOperation", true)

local Params = {
	RepoURL = "https://raw.githubusercontent.com/luau/SomeHub/main/",
	UMF = "UniversalMethodFinder",
	ROM = "RequireOnlineModule",
}
local finder, globalcontainer = loadstring(game:HttpGet(Params.RepoURL .. Params.UMF .. ".luau", true), Params.UMF)()

finder({
	readbinarystring = 'string.find(...,"binary",nil,true)', -- ! Could match some unwanted stuff (readbinarystringpropertyvalue/readbspval/getbspval)

	gethiddenproperty = 'string.find(...,"get",nil,true) and string.find(...,"h",nil,true) and string.find(...,"prop",nil,true) and string.sub(...,#...) ~= "s"',
	gethiddenproperties = 'string.find(...,"get",nil,true) and string.find(...,"h",nil,true) and string.find(...,"prop",nil,true) and string.sub(...,#...) == "s"',

	getproperties = 'string.find(...,"get",nil,true) and string.find(...,"prop",nil,true) and string.sub(...,#...) == "s" and not string.find(...,"h",nil,true)',
	getspecialinfo = 'string.find(...,"get",nil,true) and string.find(...,"spec",nil,true)',
}, true, nil, true)

local InstancePropsTest = { [Terrain] = "PhysicsGrid", [MeshPart] = "InitialSize", [UnionOperation] = "AssetId" }

for methodname, method in globalcontainer do
	for instance, propname in InstancePropsTest do
		warn(methodname, instance.ClassName, propname, pcall(method, instance, propname))
	end
end

@phoriah phoriah closed this as completed Mar 28, 2024
@phoriah
Copy link
Contributor

phoriah commented Mar 28, 2024

Feel free to continue the discussion.

@phoriah
Copy link
Contributor

phoriah commented Apr 1, 2024

Should be fixed in 4559e23 Needs to be tested & confirmed though. @loboazul666 @ActualMasterOogway

Works now, but i have an issue with the beams not being at the position they are supposed to, also i think the size of that beam is smaller

Beams (attachments) should be fixed now, lmk if you're still having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants
@loboazul666 @gamersindo1223 @phoriah @Eetblgb25 @ActualMasterOogway and others