Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fallback Support for Attributes, Tags & other NotScriptable props #7

Closed
MuhXd opened this issue Apr 10, 2024 · 9 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@MuhXd
Copy link

MuhXd commented Apr 10, 2024

Is your feature request related to a problem? Please describe.
attributes not being added when instancing places with objects with lots of attributes

Describe the solution you'd like
attributes being added to objects when save instanced

Describe alternatives you've considered
typing the attributes from dex
Additional context
We are decompling some things that require attributes, a bunch or them so it would take so much time to

@MuhXd MuhXd added the enhancement New feature or request label Apr 10, 2024
@MuhXd MuhXd changed the title [FEATURE] [FEATURE] (I think idk) Apr 10, 2024
@phoriah
Copy link
Contributor

phoriah commented Apr 10, 2024

Which executor are you using? And try to print(gethiddenproperty(InstanceWithAttributes, "AttributesSerialize")) and send f9 picture

@MuhXd
Copy link
Author

MuhXd commented Apr 10, 2024

image
image
I am using wave and this object as a example

@phoriah
Copy link
Contributor

phoriah commented Apr 11, 2024

image image I am using wave and this object as a example

That's an issue with wave's gethiddenproperty then

@phoriah
Copy link
Contributor

phoriah commented Apr 11, 2024

Our saveinstance supports every property (tags, attributes etc) by default.

@phoriah
Copy link
Contributor

phoriah commented Apr 11, 2024

image image I am using wave and this object as a example

That's an issue with wave's gethiddenproperty then

@MuhXd Report the

image image I am using wave and this object as a example

Report that error to Wave devs instead.

@phoriah phoriah closed this as completed Apr 11, 2024
@phoriah
Copy link
Contributor

phoriah commented Apr 12, 2024

We will look into adding fallback (in case gethiddenproperty fails) way to save Tags, Attributes and some other properties. But no promises

@phoriah phoriah reopened this Apr 12, 2024
@phoriah phoriah pinned this issue Apr 12, 2024
@phoriah phoriah changed the title [FEATURE] (I think idk) [FEATURE] Fallback Support for Attributes, Tags & other NotScriptable props Apr 12, 2024
@MuhXd
Copy link
Author

MuhXd commented Apr 12, 2024

umm on codex is does the same thing

@phoriah
Copy link
Contributor

phoriah commented Apr 12, 2024

umm on codex is does the same thing

It's an issue on all executors due to new Capabilities system that Roblox introduced few months ago

@phoriah
Copy link
Contributor

phoriah commented Jul 2, 2024

Is your feature request related to a problem? Please describe. attributes not being added when instancing places with objects with lots of attributes

Describe the solution you'd like attributes being added to objects when save instanced

Describe alternatives you've considered typing the attributes from dex Additional context We are decompling some things that require attributes, a bunch or them so it would take so much time to

Should be added now.

@phoriah phoriah closed this as completed Jul 2, 2024
@phoriah phoriah unpinned this issue Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants