Reorder reads and writes for itemstats aggregation. #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running a fetch request without returning the result upstream to the user, a successfully fetched item would leak its reference.
|
This is cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder reads and writes for itemstats aggregation to leverage SIMD instructions, improving code generation by ensuring that the variables are accessed in the order they are declared in memory. This change optimizes data locality and enhances the compiler's ability to generate efficient vectorized code.
See https://godbolt.org/z/7GGEM1e7j for a comparison of the generated assembly.
No functional changes.