Update to -f logic #996
Open
Update to -f logic #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…culate slab sizes, there's maximum of 10 factors which is defined as FACTOR_MAX_COUNT. - Some more logic that'll prevent having incorrect slab sizes instead of throwing an error, eg. if there's 8 byte alignment, having factor of 1 will increase next slab size by 8 bytes - No longer slabs with different sizes and same perslab will be created
|
Thanks! I like the fix for different sizes but same perslab. The rest I'm not super sure about right now: I added another feature a long time ago for specifying exact slab sizes directly. So anyone who normally wouldn't care would use the simple factor, but if you really want to hyper-optimize you can do your own factors and directly specify them. Giving multiple factors seems confusing to users. I'll think about it though and come back when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now have several -f (factors) that'll be used evenly to calculate slab sizes, there's maximum of 10 factors which is defined as FACTOR_MAX_COUNT.
Some more logic that'll prevent having incorrect slab sizes instead of throwing an error, eg. if there's 8 byte alignment, having factor of 1 will increase next slab size by 8 bytes
No longer slabs with different sizes and same perslab will be created