Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Skip downloading an image if the file name matches excluding the file extension #5147

Open
Lagicrus opened this issue Feb 1, 2024 · 2 comments · May be fixed by #5154
Open

Enhancement - Skip downloading an image if the file name matches excluding the file extension #5147

Lagicrus opened this issue Feb 1, 2024 · 2 comments · May be fixed by #5154

Comments

@Lagicrus
Copy link

Lagicrus commented Feb 1, 2024

Is it possible to add a feature or flag that would skip downloading a file if the file name to download matches a file name that already exists but ignores it if the file extension matches?
I've run into this issue recently as I've run an image optimizer/shrinker to save space, which changes the file extensions from .jpg to .avif
But when I rerun gallery-dl over the source, it starts downloading all the already downloaded files, just converted to a new file extension.

i.e. it would download test-image_1.jpg even though test-image_1.avif existed
@Lagicrus Lagicrus linked a pull request Feb 2, 2024 that will close this issue
Open
@Hrxn
Copy link
Contributor

Hrxn commented Feb 2, 2024

Well, that's one way to do it, but you should seriously consider using the "archive" option.

@Lagicrus
Copy link
Author

Lagicrus commented Feb 4, 2024

True, but if I am not mistaken, the archive option only works if

  • You've been using it from the start
  • You don't delete items which would make the archive out-of-date
    That and I am not so sure it would still count for the whole "any file ext" use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds new exists logic that can optionally ignore the file extension Lagicrus/gallery-dl
2 participants
@Hrxn @Lagicrus