Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a "worst-case" tree type to test algorithms with #272

Closed
rcurtin opened this issue Dec 29, 2014 · 1 comment
Closed

create a "worst-case" tree type to test algorithms with #272

rcurtin opened this issue Dec 29, 2014 · 1 comment

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2014

Reported by rcurtin on 30 Jun 43353975 16:03 UTC
In the paper 'Tree-Independent Dual-Tree Algorithms' (http://arxiv.org/abs/1304.4327) the general definitions for a space tree are laid out. All of the dual-tree algorithms are written in the generalized format detailed in the paper (or, well... they should be converted...). However, I'm nearly certain that the algorithms, as implemented, won't work for any arbitrary space tree type.

So, we should make some kind of space tree which is meant to test these algorithms (keep in mind it is not meant to perform the algorithm quickly).

I think it should maybe look something like this:

  • At the creation of each node, it is given a list of points which are going to be its descendants. It picks a random subset of these to be its own points, and then passes the rest of the points, plus maybe some of its own points, to its children. This way we get points that are in one level, but not the next, but then also in the one after that.
  • The convex subsets represented by each node can (and maybe should) be overlapping.
  • The way the convex subsets are expressed should not be dimension-specific. Maybe some kind of n-gon which encloses the descendant points and where n is some random number that is different at each node.
  • Some child nodes should be identical copies of the parent node.

Then, if this is implemented, we will almost certainly find that our dual-tree algorithms, as implemented, don't always work with any type of space tree.

Migrated-From: http://trac.research.cc.gatech.edu/fastlab/ticket/282

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin added this to the mlpack 1.1.0 milestone Dec 29, 2014
@rcurtin rcurtin removed their assignment Dec 30, 2014
@rcurtin rcurtin modified the milestones: mlpack 2.0.1, mlpack 2.0.0 Dec 15, 2015
@rcurtin rcurtin modified the milestones: mlpack 2.0.2, mlpack 2.0.1 Feb 4, 2016
@rcurtin rcurtin removed this from the mlpack 2.0.2 milestone Jun 5, 2016
@rcurtin
Copy link
Member Author

rcurtin commented Jan 19, 2019

I don't think this is worth the effort anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant