unify constructors of dual-tree algorithms

[rcurtin]

Reported by rcurtin on 7 May 43624460 22:08 UTC
Right now, the NeighborSearch constructor, the RangeSearch constructor, and the RASearch constructor each take the 'leafSize' parameter, which is specific to kd-trees. In addition, the actual constructor implementation is specific to kd-trees in that it hangs onto mappings for the tree when indices are reordered.

So, we must unify tree constructors so that we only need to pass the dataset they are being built on, but also we need some kind of compile-time tree trait that tells us if the tree will mix the ordering of the dataset.

Then, we can have two overloads of constructors to build the trees, and we can use that compile-time constant later to determine if we need to unmap.

[rcurtin]

Commented by saheb on 13 Aug 44100804 10:23 UTC
Hi I have made the changes and attached the patch file above as I don't have commit rights as of now, its compiled properly. Check it out :)
I will soon discuss about traits and map/unmap for the same.

[rcurtin]

Commented by rcurtin on 3 Dec 44100867 09:54 UTC
Is this tested so that the following code will work?

arma::mat randomData;
randomData.randu(10, 10000);

NeighborSearch<CoverTree<> > ns(randomData);

arma::mat distances;
arma::Mat<size_t> neighbors;
ns.Search(5, neighbors, distances);

[rcurtin]

Commented by rcurtin on 29 Mar 44516391 05:58 UTC
Ok, after a large amount of patches and commits, each of the existing five dual-tree algorithms (NeighborSearch, RangeSearch, RASearch, DualTreeBoruvka, and FastMKS) now have constructors that do not have any parameters that depend on the type of tree. So the code snippet in the previous comment works, for each type of dual-tree algorithm.