Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from -j 2 to -j ${nproc} #3707

Open
coatless opened this issue May 15, 2024 · 2 comments · May be fixed by #3708
Open

Switch from -j 2 to -j ${nproc} #3707

coatless opened this issue May 15, 2024 · 2 comments · May be fixed by #3708

Comments

@coatless
Copy link
Contributor

Glancing at the runtime of the R GitHub Actions workflow, I think we can use a few more cores.

Currently, the number of cores is set to 2; however, GitHub Actions for public repositories allows for up to 4 cores/16 GB (ubuntu-latest) or 3 cores/7 GB (macos-latest) to be present.

I suppose this issue ticket is a note to switch:

    env:
      MAKEFLAGS: "-j 2"

to:

    env:
      MAKEFLAGS: "-j $(nproc)"

Perhaps include this in the prior step as the MAKEFLAGS variables can be used when setting up R dependencies.
@rcurtin
Copy link
Member

rcurtin commented May 15, 2024

Want to give it a shot and see what happens?

In general I have noticed that compiling mlpack_test feels like it has gotten slower recently, perhaps due to our changes or perhaps due to changes to gcc, but I haven't looked deeply into it.

@coatless coatless linked a pull request May 15, 2024 that will close this issue
Open
@coatless
Copy link
Contributor Author

@rcurtin done in #3708.

Not sure about the Azure pipelines aspect; but, I can look more in-depth later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable more parallelization on the R action worker via: -j $(nproc) mlpack/mlpack
2 participants
@coatless @rcurtin