Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use profiling information during compilation #48

Closed
rcurtin opened this issue Dec 29, 2014 · 8 comments
Closed

Use profiling information during compilation #48

rcurtin opened this issue Dec 29, 2014 · 8 comments

Comments

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2014

Reported by rcurtin on 15 Aug 40301853 01:20 UTC
This should be a relatively simple task to set up (once the blocking bugs are resolved).

Using the testing framework set up in #18, tell the compiler to use profiling information to optimize FASTLIB.

We should see some speed gains from this.

Migrated-From: http://trac.research.cc.gatech.edu/fastlab/ticket/20

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin added this to the mlpack 1.1.0 milestone Dec 29, 2014
@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by speet3 on 18 Apr 41592779 02:53 UTC
(In #94) It appears I do not have the correct permission to modify the description of the ticket, so I'll just add it as a comment for now:

The following requirements are excerpted from ticket #18 for as a reminder of intended result of this ticket:

  • Build each revision of MLPACK shortly after it is checked in
  • Upon encountering a build error that was not present before, alert the developer who checked in the erroneous code with a nastygram
  • Be able to run unit tests on the code
  • Be able to run timing tests on the code (Remove fl-build system (all the build.py files) #19)
  • Be able to get profiling information for the code; CMake can compile MLPACK easily with profiling information (though I've not yet checked the code to make that change in) and then gprof can get results (Minimize preprocessor macro usage #20)
  • Compare timing information and profiling information across revisions of the code
  • Produce working executables for Windows, Linux, and OS X
  • Provide automatically built installation packages

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by speet3 on 3 Dec 41674892 09:35 UTC
Just as an FYI, this is somewhat of a two-part ticket. The build server can be made to run whatever profiling tests you want, but I will need some guidance as to what that is.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 27 Jul 41689222 11:19 UTC
I have been investigating how to do this and I actually think it may be possible to do this entirely in CMake, with a user-specified option defining whether or not to actually perform profile-guided optimization. The process is done in three steps: compile with -fprofile-generate, run a bunch of tests to emulate standard usage, then recompile with -fprofile-use. Therefore, I'll take ownership of this ticket.

@rcurtin
Copy link
Member Author

rcurtin commented Dec 29, 2014

Commented by rcurtin on 8 Nov 41699463 22:40 UTC
(In #21) No more blocked by #20; let's call that it's own ticket to add profiling support, not to replace what was done here. Then, this can be resolved while that ticket is still open.

@rcurtin rcurtin removed their assignment Dec 30, 2014
@rcurtin rcurtin modified the milestones: mlpack 2.0.1, mlpack 2.0.0 Dec 23, 2015
@rcurtin rcurtin modified the milestones: mlpack 2.0.2, mlpack 2.0.1 Feb 4, 2016
@rcurtin rcurtin removed this from the mlpack 2.0.2 milestone Jun 5, 2016
@yashsharan
Copy link

Is this issue this open?If yes ,I would like to work on this.Thanks

@rcurtin
Copy link
Member Author

rcurtin commented Feb 26, 2018

The issue has not been closed so it is not done. You are free to look into it.

@mlpack-bot
Copy link

mlpack-bot bot commented Feb 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Feb 18, 2019
@rcurtin rcurtin removed the s: stale label Feb 18, 2019
@Shandilya21
Copy link

Shandilya21 commented Apr 1, 2020

@rcurtin Is this issue is still open or closed? If open I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants