Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mp3splt fails with "buffer overflow detected ***: terminated" after upgraded to Fedora 38 #367

Open
szpak opened this issue Jul 21, 2023 · 1 comment · May be fixed by #368
Open

mp3splt fails with "buffer overflow detected ***: terminated" after upgraded to Fedora 38 #367

szpak opened this issue Jul 21, 2023 · 1 comment · May be fixed by #368

Comments

@szpak
Copy link

szpak commented Jul 21, 2023

After upgraded to Fedora 38 mp3splt has stopped working and crashes immediately with:

*** buffer overflow detected ***: terminated
fish: Job 1, 'mp3splt -t"5.00>2.00" file_exam…' terminated by signal SIGABRT (Abort)

Steps to reproduce:

  1. Get some mp3 (it crashes with everything I've tried - e.g. https://file-examples.com/wp-content/storage/2017/11/file_example_MP3_700KB.mp3 )

  2. Try to split it, sample command:

mp3splt -t"5.00>2.00" file_example_MP3_700KB.mp3

Actual result:

$ mp3splt -t"5.00>2.00" file_example_MP3_700KB.mp3
mp3splt 2.6.2 (09/11/14) - using libmp3splt 0.9.2
Matteo Trotta
Alexandru Munteanu
THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK!
Processing file 'file_example_MP3_700KB.mp3' ...
info: file matches the plugin 'mp3 (libmad)'
info: found Xing or Info header. Switching to frame mode...
info: MPEG 1 Layer 3 - 44100 Hz - Joint Stereo - FRAME MODE - Total time: 0m.42s
info: starting time mode split
*** buffer overflow detected ***: terminated
fish: Job 1, 'mp3splt -t"5.00>2.00" file_exam…' terminated by signal SIGABRT (Abort)

Expected result:

The file is split correctly.

Extra comments:

It works without any problem with Fedora 37. Probably some compilation restrictions were added in Fedora 38.

Related issue in RPMFusion Bugzilla - https://bugzilla.rpmfusion.org/show_bug.cgi?id=6720
@sergiomb2
Copy link

here is one gdb backtrace of this issue

(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0)
    at pthread_kill.c:44
#1  0x00007ffff7e188b3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007ffff7dc7abe in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007ffff7db087f in __GI_abort () at abort.c:79
#4  0x00007ffff7db160f in __libc_message (fmt=fmt@entry=0x7ffff7f2b2e6 "*** %s ***: terminated\n")
    at ../sysdeps/posix/libc_fatal.c:150
#5  0x00007ffff7eac979 in __GI___fortify_fail (msg=msg@entry=0x7ffff7f2b28c "buffer overflow detected")
    at fortify_fail.c:24
#6  0x00007ffff7eab1b4 in __GI___chk_fail () at chk_fail.c:28
#7  0x00007ffff7eaad95 in ___snprintf_chk (s=<optimized out>, maxlen=<optimized out>, flag=<optimized out>, 
    slen=<optimized out>, format=<optimized out>) at snprintf_chk.c:29
#8  0x00007ffff7f8d779 in snprintf (__fmt=0x7ffff7f9315d "%s", __n=13, __s=0x555555571482 "")
    at /usr/include/bits/stdio2.h:54
#9  splt_of_put_output_format_filename (state=0x555555565170, current_split=<optimized out>)
    at /usr/src/debug/libmp3splt-0.9.2-15.fc38.x86_64/src/oformat_parser.c:906
#10 0x00007ffff7f81956 in splt_s_split_by_time (state=state@entry=0x555555565170, error=error@entry=0x7fffffffd350, 
    split_time_length=300, number_of_files=number_of_files@entry=-1)
    at /usr/src/debug/libmp3splt-0.9.2-15.fc38.x86_64/src/splt.c:466
#11 0x00007ffff7f81b3d in splt_s_time_split (state=state@entry=0x555555565170, error=error@entry=0x7fffffffd350)
    at /usr/src/debug/libmp3splt-0.9.2-15.fc38.x86_64/src/splt.c:599
#12 0x00007ffff7f8219c in mp3splt_split (state=state@entry=0x555555565170)
    at /usr/src/debug/libmp3splt-0.9.2-15.fc38.x86_64/src/mp3splt.c:1296
#13 0x0000555555559d05 in main (argc=<optimized out>, orig_argv=<optimized out>)
    at /usr/src/debug/mp3splt-2.6.2-14.fc38.x86_64/src/mp3splt.c:872

sergiomb2 added a commit to sergiomb2/mp3splt that referenced this issue Aug 4, 2023
@sergiomb2
fix snprintf overflow
2c0bb68 
fix *** buffer overflow detected ***: terminated

fix mp3splt#367
@sergiomb2 sergiomb2 linked a pull request Aug 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix snprintf overflow sergiomb2/mp3splt
2 participants
@szpak @sergiomb2